xiangfu0 opened a new pull request, #20069: URL: https://github.com/apache/pinot/pull/20069
Compressed forward-index readers consume compressed input synchronously, but use `toDirectByteBuffer()`, whose returned views can outlive the read. Implementations with replaceable read-ahead windows therefore cannot safely lend temporary input through that API. Add `PinotDataBuffer.readWithByteBuffer()` for synchronous scoped consumption, and use it in the base chunk reader and V4 compressed context (also used by V5/V6). The default delegates to the existing view API; callbacks return independently owned decompressed output. Existing callers that retain input views keep using `toDirectByteBuffer()`. Validation: - 281 existing fixed/variable compressed-reader tests, including V4–V6, and 4 concrete buffer-backend tests pass on JDK 25. - Spotless, checkstyle, and license checks pass for both affected modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
