manakbisht commented on code in PR #20057:
URL: https://github.com/apache/pinot/pull/20057#discussion_r4410878335
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java:
##########
@@ -55,6 +56,7 @@ public class SegmentsValidationAndRetentionConfig extends
BaseJsonConfig {
private String _untrackedSegmentsDeletionBatchSize;
private String _untrackedSegmentsRetentionTimeUnit;
private String _untrackedSegmentsRetentionTimeValue;
+ private Boolean _enableHybridTableRetentionStrategy;
Review Comment:
Moved it next to the retention configs. I kept it as Boolean on purpose:
null means "fall back to controller.enable.hybrid.table.retention.strategy",
and that way existing table configs don't all pick up
"enableHybridTableRetentionStrategy": "DEFAULT" when serialized. Happy to
switch to Enablement if you'd rather match DedupConfig/UpsertConfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
