dylwylie opened a new pull request, #20089: URL: https://github.com/apache/pinot/pull/20089
## Summary Fixes `rlsFiltersApplied` reporting `true` for multi-stage queries when no row filter was applied. The multi-stage broker sets the flag whenever the access control returns a row filter list for a table, even an empty one. An empty list attaches no predicate, so the response says row-level security was applied when no rows were filtered. The `RLS_FILTERS_APPLIED` broker meter counts it the same way. The single-stage broker already skips empty lists (`BaseSingleStageBrokerRequestHandler`). This applies the same check in `MultiStageBrokerRequestHandler`. The RLS loop moves into a package-private `applyRlsFilters` method so it can be unit tested. ## Testing - New `MultiStageBrokerRequestHandlerTest#testApplyRlsFiltersIgnoresEmptyFilterList` covers a table with an empty list, one with no list, and one with filters. It fails without the fix (`expected [false] but found [true]`). - `MultiStageBrokerRequestHandlerTest`: 19 tests pass. - spotless, license and checkstyle pass on `pinot-broker`. Label suggestion: `bugfix` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
