xiangfu0 commented on code in PR #18758:
URL: https://github.com/apache/pinot/pull/18758#discussion_r4409353000
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/text/LuceneTextIndexReader.java:
##########
@@ -101,7 +106,11 @@ public LuceneTextIndexReader(String column, File indexDir,
int numDocs, TextInde
config =
TextIndexUtils.getUpdatedConfigFromPropertiesFile(propertiesFile, config);
}
- _docIdTranslator = prepareDocIdTranslator(indexDir, _column, numDocs,
_indexSearcher, config, indexFile);
+ _buildOnDictionary = config.isBuildOnDictionary();
+ // In dictionary mode the Lucene docId equals the dictId (entries are
added in dictId order and the index is
+ // force-merged to a single segment), so no docId mapping is needed.
+ _docIdTranslator = _buildOnDictionary ? NoOpDocIdTranslator.INSTANCE
Review Comment:
Fixed in cc6b047406. Both storage paths now honor the persisted
Lucene-to-dictionary mapping; dictionary IDs survive explicit Skip, and Skip is
persisted only after identity is verified.
The regression flushes three Lucene segments and forces merge order [2, 0,
1], then checks dictionary matches for directory/packed storage and explicit
Skip. All 76 focused tests and affected-module checks pass on JDK 25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
