Jackie-Jiang commented on PR #20098: URL: https://github.com/apache/pinot/pull/20098#issuecomment-6531763578
Addressed in 8ec0df7e0d. `HISTOGRAM`, `SUMARRAYLONG`/`SUMARRAYDOUBLE` and `FUNNELCOUNT` now return a new array instead of adding into `finalResult1`. The "modified in place" sentence is gone from the `mergeFinalResult` Javadoc, which now says the merge must not modify either final result, since a final result can be shared like any other column value. While checking the other merges, I also found that `FUNNELSTEPDURATIONSTATS` returned the first final result and dropped the second. Its duration statistics cannot be merged, so it no longer overrides the merge and now rejects it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
