xiangfu0 commented on code in PR #20115: URL: https://github.com/apache/pinot/pull/20115#discussion_r4435530815
########## pinot-tools/src/main/resources/conf/pinot-server.conf: ########## @@ -37,6 +37,9 @@ pinot.server.adminapi.port=8097 # Pinot Server Data Directory pinot.server.instance.dataDir=/tmp/pinot/data/server/index +# Set to false to fail startup if dataDir is missing, for deployments that prepare disks separately. +# This checks directory existence, not whether the intended disk is mounted. Review Comment: Non-blocking: this flag covers only `dataDir`. `consumerDir` (`RealtimeTableDataManager.getConsumerDir`) and tier `dataDir`s (created via `moveDirectory` in `TierBasedSegmentDirectoryLoader`) are still created on demand after startup. If those sit on separately prepared disks, it may be worth saying so here. AI-generated review via IntentLab ยท Model: Claude Opus 5.5 (claude-opus-5-5). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
