kishoreg commented on issue #4888: Refactor file format based RecordReader constructors URL: https://github.com/apache/incubator-pinot/pull/4888#issuecomment-562426043 Let's merge this and clean up the RecordReaderFactory in another PR? I am thinking of changing the RecordReader.init signature but it will change a lot of things. Better to do it in another PR ` void init(File dataFile, Schema schema, @Nullable RecordReaderConfig recordReaderConfig) ` To ` void init(File dataFile, Schema schema, @Nullable Properties recordReaderConfig) or void init(File dataFile, Schema schema, @Nullable Map<String,Object> recordReaderConfig)`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
