Jackie-Jiang commented on PR #20134: URL: https://github.com/apache/pinot/pull/20134#issuecomment-6594782050
@xiangfu0 Addressed the custom-pipeline concern in d3704c38df and replied inline. For the two other observations: - Integer-valued folded expressions: agreed. The description now limits the MSE consistency claim to keys that remain literals after SSE's existing alias/ordinal resolution, and explicitly calls out `ORDER BY CAST(2 AS INT)` resolving to select item 2. This PR preserves that existing behavior. - `OFFSET`: the assertion is intentional. When all keys are removed, the query follows ordinary unordered SSE selection, which currently ignores `OFFSET`; MSE honors it. The TODO records the server/broker work needed to align them, and the regression expectation should change with that fix. Separate tests now verify that requests retaining literal keys still honor ordered `OFFSET` handling. All 262 focused tests and the required formatting, style, and license checks passed locally on the updated commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
