xiangfu0 commented on code in PR #20021:
URL: https://github.com/apache/pinot/pull/20021#discussion_r4451375338
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##########
@@ -232,6 +232,20 @@ public class BrokerMeter implements AbstractMetrics.Meter {
"NETTY_CONNECTION_CHANNEL_ACTIVE", "nettyConnection", false);
public static final BrokerMeter NETTY_CONNECTION_CHANNEL_INACTIVE = create(
"NETTY_CONNECTION_CHANNEL_INACTIVE", "nettyConnection", false);
+ // Requests rejected because the channel's outbound queue was above its high
watermark, i.e. the send window to the
+ // server is closed (see NettyConfig.WRITE_BUFFER_HIGH_WATER_MARK_BYTES).
Each one is a query failed fast instead of
+ // being queued in direct memory behind a stalled socket.
+ public static final BrokerMeter NETTY_CONNECTION_UNWRITABLE_REJECTIONS =
create(
Review Comment:
Done in SHA. `NETTY_CONNECTION_UNWRITABLE_REJECTIONS`,
`NETTY_CONNECTION_WRITE_TIMEOUTS` and `NETTY_CONNECTION_CHANNEL_EVICTIONS` are
now tagged with the server's short name through `addMeteredValue`, the same way
as `NETTY_CONNECTION_CHANNEL_INACTIVE`. They're new in this PR, so no existing
metric changes name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
