fx19880617 commented on a change in pull request #4888: Refactor file format based RecordReader constructors URL: https://github.com/apache/incubator-pinot/pull/4888#discussion_r354717565
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java ########## @@ -42,15 +42,14 @@ import org.apache.pinot.common.config.SegmentsValidationAndRetentionConfig; import org.apache.pinot.common.config.StarTreeIndexConfig; import org.apache.pinot.common.config.TableConfig; -import org.apache.pinot.csv.data.readers.CSVRecordReaderConfig; import org.apache.pinot.spi.data.FieldSpec; import org.apache.pinot.spi.data.FieldSpec.FieldType; import org.apache.pinot.spi.data.Schema; import org.apache.pinot.common.data.StarTreeIndexSpec; import org.apache.pinot.spi.data.TimeFieldSpec; import org.apache.pinot.spi.data.TimeGranularitySpec; -import org.apache.pinot.spi.utils.JsonUtils; -import org.apache.pinot.core.data.readers.FileFormat; +import org.apache.pinot.spi.data.readers.RecordReaderFactory; Review comment: I think the reason is that we changed the signatures inside RecordReaderFactory getRecordReader(...) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
