deepthi912 opened a new pull request, #20152: URL: https://github.com/apache/pinot/pull/20152
Suggested labels: `refactor`, `cleanup` In upsert code, "snapshot" names two different things: the validDocIds / queryableDocIds bitmap persisted next to a segment, and the in-memory query-time view (`getValidDocIdsSnapshot`, `getQueryableDocIdsSnapshot`, `SegmentContext#setQueryableDocIdsSnapshot`). This makes it easy to misread which one a variable holds. This PR renames only the variables that hold the persisted bitmap, to `validDocIdsOnDiskBitmap` / `queryableDocIdsOnDiskBitmap`: - `BasePartitionUpsertMetadataManager`: the out-of-TTL add and preload paths and the reload rebuild (bitmaps loaded with `loadDocIdsFromSnapshot`), and both places a snapshot round writes them (`persistDocIdsSnapshot`). - The matching variables in `ConcurrentMapPartitionUpsertMetadataManagerTest`, `ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletesTest` and `TablesResourceTest`. Variable names and one protected method's parameter name only. No method, class, file name, config, REST, metric or log message changes, so nothing is backward-incompatible. The query-time view variables keep their names. Tests: `ConcurrentMapPartitionUpsertMetadataManagerTest` (40), `ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletesTest` (18), `TablesResourceTest` (24), all passing. Spotless, checkstyle and license checks are clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
