xiangfu0 commented on code in PR #20165:
URL: https://github.com/apache/pinot/pull/20165#discussion_r4482832561
##########
helm/pinot/templates/zookeeper/statefulset.yaml:
##########
@@ -84,9 +84,9 @@ spec:
value: {{ .Values.zookeeper.syncLimit | quote }}
- name: ZOO_MAX_CLIENT_CNXNS
value: {{ .Values.zookeeper.maxClientCnxns | quote }}
- - name: ZOO_AUTOPURGE_PURGE_INTERVAL
+ - name: ZOO_AUTOPURGE_PURGEINTERVAL
Review Comment:
On keeping the old names for a release or two: the official image never read
`ZOO_AUTOPURGE_PURGE_INTERVAL` or `ZOO_AUTOPURGE_SNAP_RETAIN_COUNT`. `git log
-S` finds no match anywhere in the 31z4/zookeeper-docker history. So the old
names have always done nothing, and keeping them only helps someone running a
custom image that reads them. Whichever way you go, please add a note to
`helm/pinot/UPGRADING.md` saying autopurge turns on after upgrade. Users who
want the old behavior can set `zookeeper.autopurge.purgeInterval: 0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
