Jackie-Jiang opened a new pull request, #20184: URL: https://github.com/apache/pinot/pull/20184
Clarify review guidance for compatibility constructors, getter order, null-check ternaries, and blank lines so reviews consistently catch these cleanup issues. Retain legacy constructors only for supported Java API contracts, while preserving mixed-version JSON compatibility independently. The guidance also prefers the non-null ternary branch first, references the existing constructor-invariant rule, keeps getters in field order, and avoids consecutive blank lines inside class bodies while preserving the import/class separator. Validation: `git diff --check` passed. Documentation only; Spotless and Checkstyle target Java sources, and the license checks exclude `kb/**`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
