codecov-io commented on issue #4897: Moving crypter classes to pinot-spi URL: https://github.com/apache/incubator-pinot/pull/4897#issuecomment-562654910 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=h1) Report > Merging [#4897](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/bc87b48055620f94dd52e56edd98d1e9fef15d35?src=pr&el=desc) will **decrease** coverage by `6.73%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4897 +/- ## ============================================ - Coverage 56.62% 49.88% -6.74% Complexity 53 53 ============================================ Files 1175 1175 Lines 62792 62792 Branches 9208 9208 ============================================ - Hits 35554 31322 -4232 - Misses 24602 29041 +4439 + Partials 2636 2429 -207 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/pinot/spi/crypt/PinotCrypterFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY3J5cHQvUGlub3RDcnlwdGVyRmFjdG9yeS5qYXZh) | `75% <ø> (ø)` | `0 <0> (?)` | | | [...in/java/org/apache/pinot/minion/MinionStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vTWluaW9uU3RhcnRlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/pinot/spi/crypt/NoOpPinotCrypter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY3J5cHQvTm9PcFBpbm90Q3J5cHRlci5qYXZh) | `40% <ø> (ø)` | `0 <0> (?)` | | | [...org/apache/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9Db250cm9sbGVyU3RhcnRlci5qYXZh) | `68.27% <ø> (-1.73%)` | `0 <0> (ø)` | | | [.../server/starter/helix/SegmentFetcherAndLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50RmV0Y2hlckFuZExvYWRlci5qYXZh) | `0% <ø> (-64.77%)` | `0 <0> (ø)` | | | [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `5.38% <ø> (-55.09%)` | `0 <0> (ø)` | | | [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...re/data/manager/config/TableDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvY29uZmlnL1RhYmxlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | ... and [253 more](https://codecov.io/gh/apache/incubator-pinot/pull/4897/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=footer). Last update [bc87b48...0ee2840](https://codecov.io/gh/apache/incubator-pinot/pull/4897?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
