xiangfu0 commented on code in PR #20171:
URL: https://github.com/apache/pinot/pull/20171#discussion_r4489578225
##########
pinot-core/src/main/java/org/apache/pinot/core/routing/timeboundary/TimeBoundaryStrategyService.java:
##########
@@ -57,11 +57,12 @@ public static void setInstance(TimeBoundaryStrategyService
service) {
_instance = service;
}
+ /// Returns a new strategy instance so logical-table-specific initialization
is not shared between requests.
Review Comment:
Nit, not blocking: this changes the SPI contract for third-party strategies.
Their no-arg constructor now runs on every lookup, not once at startup.
Consider adding the same note to the `TimeBoundaryStrategy` interface javadoc:
implementations are request-scoped and should have a cheap no-arg constructor,
with any shared caches held in static or external state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
