Jackie-Jiang opened a new pull request, #20158: URL: https://github.com/apache/pinot/pull/20158
## Summary Adds a `ControllerTest.overrideClusterConfigs(Map<String, String>)` hook, next to `overrideControllerConf`, so a test can set the cluster configs a controller starts with without subclassing the controller starter. Before the controller starts, `startController` writes the configs from the hook to the Helix cluster with `HelixSetupUtils.setupHelixClusterWithDefaultConfigs`, the same call the controller uses for its own `getDefaultClusterConfigs()`. That call creates the cluster if needed and writes only keys that are not set yet. So the test's values take precedence over the starter's defaults, and the controller still fills in every other default. A value changed at runtime keeps its value across `restartController`, as it would in production. Previously, changing a default cluster config meant subclassing the controller starter and overriding `getDefaultClusterConfigs()` in each test. Updating the cluster config after startup misses whatever reads it while the controller starts. The hook does nothing by default, and `startController` skips the write when it is empty, so existing tests are unaffected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
