xiangfu0 commented on code in PR #19887:
URL: https://github.com/apache/pinot/pull/19887#discussion_r4509672288
##########
pinot-common/src/main/java/org/apache/pinot/common/evaluator/GroovyFunctionEvaluator.java:
##########
@@ -93,9 +105,25 @@ public static String getGroovyExpressionPrefix() {
return GROOVY_EXPRESSION_PREFIX;
}
- /// This method is used to parse the Groovy script and check if the script
is valid.
+ /// Controls new ingestion evaluator and validation-script compilation in
this JVM. Existing evaluators and query
+ /// evaluators are unaffected. Ingestion Groovy remains enabled until a
service configures its policy.
Review Comment:
Non-blocking. "Existing evaluators … are unaffected" only lasts until
evaluators get rebuilt, which happens often. The gate also hits each new
consuming segment (`ExpressionTransformer`/`FilterTransformer`), derived-column
reload (`BaseDefaultColumnHandler`), minion `TransformFunctionPartitioner`,
`CustomFunctionEnricher` and `SchemaUtils`/`TableConfigUtils` validation. Could
the Javadoc say that turning the flag on breaks consumption, reload and minion
tasks for tables that still have Groovy transforms? That would help #19888
reviewers and operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
