manakbisht opened a new pull request, #20210: URL: https://github.com/apache/pinot/pull/20210
GET /tasks/subtask/workers/progress returned 500 whenever any minion responded. getSubtaskOnWorkerProgress requests progress with multiRequestPerServer=true and maps each response back to its worker by looking up the response key in a URL -> worker id map. Since #13314, CompletionServiceHelper suffixes those keys with "__<count>", so the lookup never matched. Every worker's progress was stored under a null key, overwriting the others, and serializing the map failed with "Null key for a Map not allowed in JSON". Strip the "__<count>" suffix before looking up the worker id. testGetSubtaskWithGivenStateProgress mocked the helper with plain URL keys, which hid the bug. Use the "__1" keys the helper actually returns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
