Jackie-Jiang commented on PR #20202: URL: https://github.com/apache/pinot/pull/20202#issuecomment-6779553247
Following up on [the review](https://github.com/apache/pinot/pull/20202#pullrequestreview-5836817644): rebased onto `master` at `45feee7d2d` and addressed all three inline findings in the refreshed head `7c5637dc3e`. Fresh validation with the upgraded dependencies passed: 24 focused tests, the scoped package build, formatting/checkstyle/license checks, and both live BATCH scenarios. Repeated multi-stage and lookup joins succeeded; normal shutdown left no children or quickstart data. After `SIGKILL` of the parent, both server JVMs exited in 5.45 seconds and all 15 checked ports were released without fallback cleanup. The title and description now explicitly cover all multi-server subclasses using `Quickstart.execute()`, including the four-server overrides. Single-server subclasses stay embedded, and direct `QuickstartRunner` callers opt in. The CI coverage gap for other forked subclasses remains as noted; the fresh live checks above cover two-server BATCH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
