anuragrai16 commented on code in PR #19529:
URL: https://github.com/apache/pinot/pull/19529#discussion_r4534514528


##########
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentConsumerInfo.java:
##########
@@ -31,23 +33,41 @@ public class SegmentConsumerInfo {
   private final long _lastConsumedTimestamp;
   private final Map<String, String> _partitionToOffsetMap;
   private final PartitionOffsetInfo _partitionOffsetInfo;
+  // FQCN of the StreamMessageDecoder instantiated on the consumer, or null if 
decoder init has not completed.
+  @Nullable
+  private final String _decoderClassName;
+
+  /// Kept for source and binary compatibility with callers that build this 
DTO without the decoder class name. Not a
+  /// Jackson creator; deserialization goes through the `@JsonCreator` 
constructor below.
+  public SegmentConsumerInfo(String segmentName, String consumerState, long 
lastConsumedTimestamp,
+      Map<String, String> partitionToOffsetMap, PartitionOffsetInfo 
partitionOffsetInfo) {
+    this(segmentName, consumerState, lastConsumedTimestamp, 
partitionToOffsetMap, partitionOffsetInfo, null);
+  }
 
+  @JsonCreator
   public SegmentConsumerInfo(@JsonProperty("segmentName") String segmentName,
       @JsonProperty("consumerState") String consumerState,
       @JsonProperty("lastConsumedTimestamp") long lastConsumedTimestamp,
       @JsonProperty("partitionToOffsetMap") Map<String, String> 
partitionToOffsetMap,
-      @JsonProperty("partitionOffsetInfo") PartitionOffsetInfo 
partitionOffsetInfo) {
+      @JsonProperty("partitionOffsetInfo") PartitionOffsetInfo 
partitionOffsetInfo,
+      @JsonProperty("decoderClassName") @Nullable String decoderClassName) {
     _segmentName = segmentName;
     _consumerState = consumerState;
     _lastConsumedTimestamp = lastConsumedTimestamp;
     _partitionToOffsetMap = partitionToOffsetMap;
     _partitionOffsetInfo = partitionOffsetInfo;
+    _decoderClassName = decoderClassName;
   }
 
   public String getSegmentName() {
     return _segmentName;
   }
 
+  @Nullable
+  public String getDecoderClassName() {

Review Comment:
   Done, moved after `getPartitionOffsetInfo()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to