KKcorps commented on PR #20118: URL: https://github.com/apache/pinot/pull/20118#issuecomment-6793086578
This comment comes from a model of upsert thread orders that StarTree runs on upsert PRs. **The model found no new bad thread order at this head. The check that now refuses to resume until every server has loaded only makes a resume wait longer, so it adds no order that today's normal rollovers cannot already reach.** I modeled the pause as a force commit that holds back the next consuming segment, and the resume as the segment that `ensureAllPartitionsConsuming` then creates. A resume held until loading finishes and a resume at any time both ran in a 76 minute search of 7,937 runs, with restarts and rebalances during the pause, on regular and pauseless tables. Eight of the bad orders it found passed through a pause, and each breaks the same way with the pause removed. The model covers one replica of one partition, so counting across several servers, SHADOW mode, the logical table rejection and dedup were not checked. <!-- upsert-model-check head=8627a27ef6b81d9c09d27f82771842c2c065268f --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
