Jackie-Jiang opened a new pull request, #20260:
URL: https://github.com/apache/pinot/pull/20260

   `PrioritySchedulerTest.testOneQuery` can finish the query before the 
scheduler acquires its next idle permit, causing intermittent `expected [3] but 
found [4]` failures ([CI 
example](https://github.com/apache/pinot/actions/runs/43459433147/job/132002092160?pr=20256)).
 Wait up to 10 seconds for the expected permit count, and always stop the 
scheduler and its executors in `finally`.
   
   Validation:
   - `./mvnw -pl pinot-core -am -Dtest=PrioritySchedulerTest 
-Dsurefire.failIfNoSpecifiedTests=false -Dmaven.compiler.showDeprecation=true 
-Dmaven.compiler.showWarnings=true test`: 7 tests passed.
   - A local harness forced the failing interleaving and verified the bounded 
wait succeeds after the scheduler resumes.
   - Spotless, Checkstyle, and license formatting/checks passed for 
`pinot-core`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] Fix idle-permit race in Pr... Jackie-Jiang (via GitHub) via commits

Reply via email to