xiangfu0 commented on code in PR #20261:
URL: https://github.com/apache/pinot/pull/20261#discussion_r4570456082
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandlerTest.java:
##########
@@ -63,9 +63,10 @@ public void testOverwrite() {
@Test
public void testForceOverwrite() {
- testMerge(true, 0, true, 0, "field4", 0, true);
+ testMerge(true, 0, true, 0L, "field4", 0L, true);
testMerge(true, 0, false, 1, "field4", 1, false);
- testMerge(false, 0, true, 1, "field4", 1, true);
+ // A null new value stays null (with the schema default) instead of
overwriting with the default value
+ testMerge(false, 3, true, 0L, "field4", 0L, true);
Review Comment:
Nit (non-blocking): the description uses STRING (`"null"`) as the example,
but these tests only cover a single-value LONG. A STRING or multi-value
FORCE_OVERWRITE case would also cover the `Object[]{default}` default in
`setMergedValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
