tarun11Mavani commented on PR #19776: URL: https://github.com/apache/pinot/pull/19776#issuecomment-6941715295
@Jackie-Jiang thanks for the review. I've opened follow-ups for the two remaining cases: 1. Archive-root collision (P1): https://github.com/apache/pinot/pull/20283 Skips the sweep of an archive root when a live table has that name, skips non-directory entries before the empty-directory cleanup, and adds a regression for a table named `Deleted_Segments_Metadata`. 2. Stale sidecar on refresh (P2): https://github.com/apache/pinot/pull/20284 (draft) I'd like your view before taking this further. It deletes the old sidecar on every refresh and drops the exemption. That also changes behavior when the sidecar is correct: a job that stages its tar and a fresh sidecar in the deep-store table directory now loses the sidecar on refresh (SEGMENT-mode refresh already does this). I found no in-repo runner or example that stages output this way, only one test, but I can't see external setups. The alternative is to keep the exemption and compare the sidecar's CRC with the request metadata, deleting the sidecar only on a mismatch. Correct sidecars survive, at the cost of a sidecar download and untar in that case. Which would you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
