noy-solvin commented on PR #19982: URL: https://github.com/apache/pinot/pull/19982#issuecomment-7003842946
Addressed all review feedback items in commit ce96bd0f1996718c61b234a9b5129f869b89d9b6: 1. **Ping Health Check (`QueryRouter.ping()`):** Updated ping check to reject synthetic deserialization failure DataTables (verifying `dataTable.getExceptions().isEmpty()`). 2. **Channel Identity / Overloads:** Removed no-channel overloads `markServerDeserializationError` and `receiveDeserializationError`, requiring explicit `Channel` parameter and updating tests. 3. **Malformed Frame Cost Attribution:** Passed `0, 0` for `responseSize` and `deserializationTimeMs` during broadcast deserialization error so individual malformed frame costs are not charged $N$ times across $N$ pending queries. 4. **DataTableHandler Comment:** Updated comment describing channel closure as a conservative recovery policy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
