kishoreg commented on a change in pull request #4956: Make plugin manager to
load plugins based on environment variables
URL: https://github.com/apache/incubator-pinot/pull/4956#discussion_r362677030
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
##########
@@ -49,6 +89,7 @@ private PluginManager() {
* @param directory
*/
public void load(String pluginName, File directory) {
+ LOGGER.info("Trying to load plugin [{}] from location [{}]", pluginName,
directory);
Review comment:
Add another log to say that the plugin was loaded successfully. Maybe do
this in the caller and catch the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]