mayankshriv commented on a change in pull request #4964: Sql query endpoint URL: https://github.com/apache/incubator-pinot/pull/4964#discussion_r364406813
########## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java ########## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.client; + +import com.fasterxml.jackson.databind.JsonNode; + + +/** + * ResultSet which contains the ResultTable from the broker response of a sql query. + */ +class ResultTableResultSet extends AbstractResultSet { + private JsonNode _rowsArray; + private JsonNode _columnNamesArray; + private JsonNode _columnDataTypesArray; Review comment: Can we replace name and type with schema, and schema can be within metadata field. This way, we can add more metadata as needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
