Jackie-Jiang commented on a change in pull request #4979: Update quota manager
to reduce zk access
URL: https://github.com/apache/incubator-pinot/pull/4979#discussion_r366134386
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/QueryQuotaConfig.java
##########
@@ -20,16 +20,21 @@
import com.google.common.util.concurrent.RateLimiter;
import javax.annotation.Nonnull;
+import org.apache.pinot.common.utils.CommonConstants;
public class QueryQuotaConfig {
private RateLimiter _rateLimiter;
private HitCounter _hitCounter;
+ private int _numOnlineBrokers;
+ private int _tableConfigStatVersion;
- public QueryQuotaConfig(@Nonnull RateLimiter rateLimiter, @Nonnull
HitCounter hitCounter) {
+ public QueryQuotaConfig(@Nonnull RateLimiter rateLimiter, @Nonnull
HitCounter hitCounter, @Nonnull int numOnlineBrokers, @Nonnull int
tableConfigStatVersion) {
Review comment:
(nit) remove the nonnull annotation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
