kishoreg commented on a change in pull request #4993: Support Text Search (both 
offline and realtime)
URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r367718493
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
 ##########
 @@ -608,8 +671,27 @@ public void destroy() {
     // clear map now that index is closed to prevent accidental usage
     _indexReaderWriterMap.clear();
 
-    for (RealtimeInvertedIndexReader index : _invertedIndexMap.values()) {
-      index.close();
+    for (InvertedIndexReader index : _invertedIndexMap.values()) {
 
 Review comment:
   same here, lets think about folding this into invertedindexreader without 
having to check for the instanceof

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to