npawar commented on a change in pull request #4994: Make sql as default query
format.
URL: https://github.com/apache/incubator-pinot/pull/4994#discussion_r368041313
##########
File path: pinot-controller/src/main/resources/static/js/init.js
##########
@@ -67,13 +67,13 @@ $(document).ready(function() {
// execute query and draw the results
var query = EDITOR.getValue().trim();
var traceEnabled = document.getElementById('trace-enabled').checked;
- var groupByModeSQL = document.getElementById('group-by-mode-sql').checked;
- var responseFormatSQL =
document.getElementById('response-format-sql').checked;
+ var groupByModePQL = document.getElementById('group-by-mode-pql').checked;
+ var responseFormatPQL =
document.getElementById('response-format-pql').checked;
var queryOptions = undefined;
- if (groupByModeSQL === true) {
+ if (groupByModePQL !== true) {
queryOptions = "groupByMode=sql";
}
- if (responseFormatSQL === true) {
+ if (responseFormatPQL !== true) {
if (queryOptions === undefined) {
Review comment:
Is the goal to invoke the new sql endpoint, or just set these options? If
it's the former, we need a new endpoint on the controller "/sql", similar to
"pql" which is in PqlQueryResource. Inside executeQuery method (called on line
83) we need to invoke "sql" endpoint accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
