chenboat commented on a change in pull request #4995: Decouple server instance
id with hostname/port config.
URL: https://github.com/apache/incubator-pinot/pull/4995#discussion_r368172418
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -192,6 +192,9 @@ public ServerType getServerType() {
public static final String CONFIG_OF_REQUEST_HANDLER_FACTORY_CLASS =
"pinot.server.requestHandlerFactory.class";
public static final String CONFIG_OF_NETTY_PORT =
"pinot.server.netty.port";
public static final String CONFIG_OF_ADMIN_API_PORT =
"pinot.server.adminapi.port";
+ // A logical instance id is one which does not contain server host name
and/or port info. E.g., server1.
+ // It is by default disabled.
+ public static final String CONFIG_OF_USE_LOGICAL_INSTANCE_ID =
"pinot.server.logical.instance.id.enabled";
Review comment:
This config flag is used only for server start and mainly used for backward
compatibility. It controls if we want to overwrite the host/port info in zk
using those found server config. The current behavior is to extract hostname
from instance id if instance id is found in server config. We do not want to
break these use cases for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
