mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r364456350
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ########## @@ -80,9 +84,9 @@ private final long _startTimeMillis = System.currentTimeMillis(); private final String _segmentName; - private final Schema _schema; + private final Schema _originalSchema; private final int _capacity; - private final SegmentMetadata _segmentMetadata; + private final SegmentMetadata _originalSegmentMetadata; Review comment: I would prefer to leave the names as is, and rename the new fields as `_columnsAddedDuringConsumption` or something like that. We can wait for others to chime in before we rename stuff ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
