kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#discussion_r368759896
########## File path: pinot-tools/src/main/resources/appAssemblerScriptTemplate ########## @@ -107,6 +107,37 @@ if [ -n "$CLASSPATH_PREFIX" ] ; then CLASSPATH=$CLASSPATH_PREFIX:$CLASSPATH fi +if [ -z "$PLUGINS_DIR" ] ; then + PLUGINS_DIR="$BASEDIR"/plugins +fi + +if [[ -d "$PLUGINS_DIR" ]] ; then Review comment: we can skip this if PLUGINS_CLASSPATH is already set ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
