mcvsubbu commented on a change in pull request #5115: Refactor the data source
to include all information needed for query execution
URL: https://github.com/apache/incubator-pinot/pull/5115#discussion_r388513187
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -188,7 +197,7 @@ public long getLatestIngestionTimestamp() {
// Initialize for each column
for (FieldSpec fieldSpec : _physicalFieldSpecs) {
String column = fieldSpec.getName();
- _maxNumValuesMap.put(column, 0);
+ _numValuesInfoMap.put(column, new NumValuesInfo());
Review comment:
Can we re-use the NumValuesInfo object instance by adding a clear method? I
know we have been really careful about minimizing gc impact in this path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
