jackjlli commented on a change in pull request #5116: Add Azure Data Lake Gen2
connector for PinotFS
URL: https://github.com/apache/incubator-pinot/pull/5116#discussion_r391856425
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java
##########
@@ -103,8 +106,13 @@ public boolean move(URI srcUri, URI dstUri, boolean
overwrite)
}
} else {
// ensures the parent path of dst exists.
- URI parentUri = Paths.get(dstUri).getParent().toUri();
- mkdir(parentUri);
+ try {
+ Path parentPath = Paths.get(dstUri.getPath()).getParent();
Review comment:
Can you add a test for testing the case when the scheme doesn't match then
throw the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
