mcvsubbu commented on a change in pull request #4914: [POC] By-passing deep-store requirement for Realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4914#discussion_r403150455
########## File path: pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java ########## @@ -123,6 +123,9 @@ public static final String PARAM_MEMORY_USED_BYTES = "memoryUsedBytes"; public static final String PARAM_SEGMENT_SIZE_BYTES = "segmentSizeBytes"; public static final String PARAM_REASON = "reason"; + // Controls whether servers upload segments to the controller during LLC segment completion protocol. + public static final String PARAM_SEGMENT_UPLOAD_TO_CONTROLLER = "enableSegmentUploadToController"; Review comment: Why do you need this? Configure your own split committer class and use that on the server. Enable split commits all the time ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
