fx19880617 commented on a change in pull request #5132: Optimize
ExpressionFilterOperator
URL: https://github.com/apache/incubator-pinot/pull/5132#discussion_r403365760
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/DocIdSetOperator.java
##########
@@ -36,30 +35,20 @@
public class DocIdSetOperator extends BaseOperator<DocIdSetBlock> {
private static final String OPERATOR_NAME = "DocIdSetOperator";
- private static final ThreadLocal<int[]> THREAD_LOCAL_DOC_IDS = new
ThreadLocal<int[]>() {
- @Override
- protected int[] initialValue() {
- return new int[DocIdSetPlanNode.MAX_DOC_PER_CALL];
- }
- };
+ private static final ThreadLocal<int[]> THREAD_LOCAL_DOC_IDS =
+ ThreadLocal.withInitial(() -> new
int[DocIdSetPlanNode.MAX_DOC_PER_CALL]);
private final BaseFilterOperator _filterOperator;
private final int _maxSizeOfDocIdSet;
private FilterBlockDocIdSet _filterBlockDocIdSet;
private BlockDocIdIterator _blockDocIdIterator;
private int _currentDocId = 0;
- private boolean _threadLocal = true;
-
- public DocIdSetOperator(@Nonnull BaseFilterOperator filterOperator, int
maxSizeOfDocIdSet) {
- this(filterOperator, maxSizeOfDocIdSet, true);
- }
- public DocIdSetOperator(@Nonnull BaseFilterOperator filterOperator, int
maxSizeOfDocIdSet, boolean threadLocal) {
+ public DocIdSetOperator(BaseFilterOperator filterOperator, int
maxSizeOfDocIdSet) {
Review comment:
This is good.
The DocIdSet creation logic is moved outside.
See
https://github.com/apache/incubator-pinot/pull/5132/files#diff-48213157488bdb6aa43c2f6da8d2a940R131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
