Jackie-Jiang commented on a change in pull request #5221: Add a new server api for download of segments. URL: https://github.com/apache/incubator-pinot/pull/5221#discussion_r408350454
########## File path: pinot-server/src/test/java/org/apache/pinot/server/api/BaseResourceTest.java ########## @@ -58,8 +59,8 @@ protected static final String TABLE_NAME = "testTable"; private final Map<String, TableDataManager> _tableDataManagerMap = new HashMap<>(); - protected final List<ImmutableSegment> _indexSegments = new ArrayList<>(); - + protected final List<ImmutableSegment> _realtimeIndexSegments = new ArrayList<>(); Review comment: Why do you need to separate realtime and offline segments? They should be handled in the same way right? Also the realtime index segments are not CONSUMING segment, but COMPLETED segment, which is a little bit confusing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
