siddharthteotia commented on a change in pull request #5267: Re-implement
ORCRecordReader
URL: https://github.com/apache/incubator-pinot/pull/5267#discussion_r410357958
##########
File path:
pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java
##########
@@ -95,25 +171,151 @@ public GenericRow next()
@Override
public GenericRow next(GenericRow reuse)
throws IOException {
- _recordReader.nextBatch(_reusableVectorizedRowBatch);
- return _recordExtractor.extract(_reusableVectorizedRowBatch, reuse);
+ int numFields = _orcFields.size();
Review comment:
The fact that we have to materialize the data read immediately into row
loses any benefit we could have got from vectorization. May be if we do this in
bulk manner, it could change things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
