npawar commented on issue #5268: URL: https://github.com/apache/incubator-pinot/issues/5268#issuecomment-616703019
Hi @reallocf , Thanks for taking this on! Your understanding is right. What you proposed makes sense. My only concern with having a top level filter element, is that we won't know whether it needs to be applied on source or destination. This will not be a problem, if the expression applies just to the source or to the destination column. But what if the expression applies to both? `timestamp >x && maxBid > y`. Would it be better if it's defined with each column spec? If it's top level, should we make it a list? Should we support expressions such as `column1 + column2 > x`? Also, have you gone through the diagram in this doc: https://docs.google.com/document/d/13BywJncHrLAFLm-qy4kfKaPxXfAg9XE5v3_fk9sGVSo/edit#heading=h.4kdvsjcasspk It shows the various stages that the Record goes through. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
