mcvsubbu commented on a change in pull request #5277:
URL: https://github.com/apache/incubator-pinot/pull/5277#discussion_r414698216
##########
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java
##########
@@ -131,7 +140,15 @@ public
ServerSegmentCompletionProtocolHandler(ServerMetrics serverMetrics, Strin
return SegmentCompletionProtocol.RESP_NOT_SENT;
}
- return uploadSegment(url, params.getSegmentName(), segmentTarFile);
+ Server2ControllerSegmentUploader segmentUploader= null;
+ try {
+ segmentUploader = new Server2ControllerSegmentUploader(LOGGER,
Review comment:
I looked up the code, and it seems that we sanitize the url returned by
the controller, but then we pass strings around. We need to clean this up, but
it can be in a later PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
