npawar commented on a change in pull request #5303:
URL: https://github.com/apache/incubator-pinot/pull/5303#discussion_r416025871
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java
##########
@@ -167,8 +168,10 @@ public HLRealtimeSegmentDataManager(final
RealtimeSegmentZKMetadata realtimeSegm
// create and init stream level consumer
_streamConsumerFactory =
StreamConsumerFactoryProvider.create(_streamConfig);
String clientId = HLRealtimeSegmentDataManager.class.getSimpleName() + "-"
+ _streamConfig.getTopicName();
+ Set<String> sourceFields = SchemaFieldExtractorUtils.extract(schema);
Review comment:
Renamed the method to `extractSourceFields`. It should be source fields
- we get the source fields upfront and pass it to the decoder/reader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
