mayankshriv commented on pull request #5316: URL: https://github.com/apache/incubator-pinot/pull/5316#issuecomment-622154869
> can we simplify the way we define the expression? > for e.g. > `select distinctCountThetaSketch(tsCol, "dim1='foo', dim2='bar', "dim1 = 'foo and dim2='bar')` > to > `select distinctCountThetaSketch(tsCol, "dim1='foo'", "dim2='bar'", "1 AND 2")` Yes agree, this is a good idea, specially in case when predicates are long strings. Will address that in following PRs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
