siddharthteotia commented on a change in pull request #5240:
URL: https://github.com/apache/incubator-pinot/pull/5240#discussion_r419567912
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java
##########
@@ -54,6 +54,12 @@ public static BaseFilterOperator
getLeafFilterOperator(PredicateEvaluator predic
Predicate.Type predicateType = predicateEvaluator.getPredicateType();
+ //Only for dictionary encoded columns and offline data sources
+ if (predicateType == Predicate.Type.RANGE && dataSource.getDictionary() !=
null
Review comment:
Why only dictionary encoded? For raw columns, each range could be a
range of start and end raw values instead of dictIds. The data structure could
be sorted on start raw values (just like it is on start dictIds)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
