reallocf commented on a change in pull request #5326: URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r422550932
########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/function/DefaultFunctionEvaluator.java ########## @@ -50,11 +50,16 @@ public DefaultFunctionEvaluator(String expression) throws Exception { + this(expression, FunctionRegistryFactory.getFunctionRegistry()); Review comment: I think I'm creating individual `DefaultFunctionRegistry`s in the right place now, but still not 100% sure. Let me know - thanks! :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org