chenboat commented on pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#issuecomment-635136647
This PR is too big to review effectively IMO. 89 files in total. Can you break it down to 3-4 smaller PRs for review: one covering method removal; 1 or 2 PR each covering a new added major classes (e.g., SortedIndexBasedFilterOperator.java). > Removed the methods that complicate the code but provide no value: > > * BlockDocIdSet > > * getRaw > * FilterBlockDocIdSet > > * getMinDocId > * getMaxDocId > * setStartDocId > * setEndDocId > * BlockDocIdIterator > > * currentDocId > * ScanBasedDocIdIterator > > * isMatch > > Uniformed the behavior of all filter-related classes to bound the return docIds with numDocs > Simplified the logic of AND/OR handling > Pushed down the AND smart handling logic to BlockDocIdIterator to ensure the best performance: > > * AndDocIdSet might return RangelessBitmapDocIdIterator which can be merged with other iterators > * OrDocIdSet might return BitmapDocIdIterator which can be merged with other iterators > > Tested all the queries (10K PQL, 10K SQL) within the query file using HybridClusterIntegrationTest ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
