Jackie-Jiang commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-pinot/pull/5459#discussion_r432207006
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -51,7 +51,7 @@
import org.apache.pinot.common.metrics.BrokerMetrics;
import org.apache.pinot.common.request.BrokerRequest;
import org.apache.pinot.common.utils.CommonConstants;
-import
org.apache.pinot.common.utils.CommonConstants.Helix.StateModel.RealtimeSegmentOnlineOfflineStateModel;
+import
org.apache.pinot.common.utils.CommonConstants.Helix.StateModel.SegmentOnlineOfflineStateModel;
Review comment:
@mcvsubbu If we want to further clean it up, we can merge the
BrokerStateModel and SegmentStateModel and put all instance states (`ONLINE`,
`CONSUMING`, `OFFLINE`, `ERROR`) under `CommonConstants.Helix.InstanceState`.
Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
