Jackie-Jiang commented on a change in pull request #5531:
URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437749424
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -667,21 +666,23 @@ protected static Expression
invokeCompileTimeFunctionExpression(Expression funcE
function.getOperands().set(i, operand);
}
String funcName = function.getOperator();
- if (FunctionRegistry.containsFunctionByName(funcName) && compilable) {
Review comment:
`FunctionRegistry.getFunctionByName()` can handle function name not
registered by returning `null`. I have a `null` check after this to save the
extra hash lookup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
