npawar commented on pull request #5597: URL: https://github.com/apache/incubator-pinot/pull/5597#issuecomment-648347552
> Can you add some tests for filter expressions like a > 5 && b < 6 ? > You should be able to set up an ingestion stream with a few records and assert on what made it and what did not? > > Overall, since we are modifying tableConfig, please get at least one more review. I suggest Jackie The SegmentGenerationWithFilter test is testing that scenario: https://github.com/apache/incubator-pinot/pull/5597/files#diff-96ecfde3e8fe147dca591c7ee6c3c563 I plan to add an integration test soon, for all transformations ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
