ianvkoeppe commented on a change in pull request #5745:
URL: https://github.com/apache/incubator-pinot/pull/5745#discussion_r460209486
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -1087,6 +1084,22 @@ private void attachTimeBoundary(String rawTableName,
BrokerRequest brokerRequest
}
}
+ /**
+ * The time boundary filter string splits queries to offline and realtime
pinot tables based on the current high
+ * watermark of available segments in the offline table. By default, Pinot
serves all segments from offline up to
+ * the latest segment (exclusive), and everything else from realtime.
However, one can configure Pinot to serve
+ * the latest offline segment inclusively via config.
+ */
+ private String getTimeBoundaryFilter(String offlineTableName, String
timeValue, boolean isOfflineRequest) {
+ boolean shouldServeOfflineSegmentsImmediately =
Optional.ofNullable(_tableCache.getTableConfig(offlineTableName).getQueryConfig())
+ .map(QueryConfig::getServeOfflineSegmentsImmediately)
+ .orElse(false);
+ String open = isOfflineRequest || !shouldServeOfflineSegmentsImmediately ?
"(" : "[";
Review comment:
Refactored similar to the above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
